X.509: Fix crash caused by NULL pointer
authorTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Thu, 7 Jan 2021 09:28:55 +0000 (17:28 +0800)
committerSalvatore Bonaccorso <carnil@debian.org>
Wed, 20 Jan 2021 16:40:43 +0000 (16:40 +0000)
commit3dd8b0a66c292255587a5c5e785d19c45a171c14
tree75722aa392103c039766ace3110602991fdd038e
parent2ab6a2e45f0e6e741ddda2f09fe1c8d0e067a464
X.509: Fix crash caused by NULL pointer

Origin: https://lore.kernel.org/linux-crypto/20210107092855.76093-1-tianjia.zhang@linux.alibaba.com/
Bug-Debian: https://bugs.debian.org/979496

On the following call path, `sig->pkey_algo` is not assigned
in asymmetric_key_verify_signature(), which causes runtime
crash in public_key_verify_signature().

  keyctl_pkey_verify
    asymmetric_key_verify_signature
      verify_signature
        public_key_verify_signature

This patch simply check this situation and fixes the crash
caused by NULL pointer.

Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate verification")
Cc: stable@vger.kernel.org # v5.10+
Reported-by: Tobias Markus <tobias@markus-regensburg.de>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name X.509-Fix-crash-caused-by-NULL-pointer.patch
crypto/asymmetric_keys/public_key.c